Attention is currently required from: pespin, daniel. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29365 )
Change subject: ipa: Allow users closing lower layer tcp/ipa connections ......................................................................
Patch Set 2: Code-Review-1
(5 comments)
File src/input/ipaccess.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/29365/comment/68b329ce_3fa67fa8 PS2, Line 1151: (unrelated ws)
https://gerrit.osmocom.org/c/libosmo-abis/+/29365/comment/5d52e9bf_00d81e6e PS2, Line 1174: e1inp_ipa_bts_rsl_close_n(line, trx_nr); handle rc
https://gerrit.osmocom.org/c/libosmo-abis/+/29365/comment/2b5a9fbb_3adfc827 PS2, Line 1179: is moving this to above an unrelated change?
https://gerrit.osmocom.org/c/libosmo-abis/+/29365/comment/73c1a32a_269522b2 PS2, Line 1208: /* Close the underlaying IPA TCP socket of an RSL link */ "underlying"
https://gerrit.osmocom.org/c/libosmo-abis/+/29365/comment/0d6f3e80_6e143005 PS2, Line 1215: "trx_nr (%d) out of range\n", trx_nr); use line width of 120?