Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email ) Change subject: trxcon/l1sched: rework dequeueing of PDCH Tx prims ...................................................................... Patch Set 1: (1 comment) File src/host/trxcon/src/sched_lchan_pdtch.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34523/comment/1381504c_cee14b33 PS1, Line 110: llist_for_each_entry(msg, &lchan->tx_prims, list) { this needs to be llist_for_each_entry_safe afaiu? It would be easier maybe simply using a while (llist_first_entry()) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I439615639b8e840b9fd4f3af6934d9f298f32216 Gerrit-Change-Number: 34523 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Sep 2023 09:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment