Attention is currently required from: fixeria, laforge. Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 3: (2 comments) File src/vty/command.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17708): https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/6361c0d1_b69980a9?… : PS3, Line 3465: LOGP(DLGLOBAL, LOGL_ERROR, "Failed to allocate memroy, syncing without thread.\n"); 'memroy' may be misspelled - perhaps 'memory'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17708): https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/d3420064_66abb795?… : PS3, Line 3468: strcpy(sync_config, config_file); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 10:51:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No