Attention is currently required from: fixeria, laforge.

jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email )

Change subject: After writing VTY config, run sync() in a different thread ......................................................................

Patch Set 2:

(6 comments)

Patchset:

PS2:

If we only care about the new file (not to the backup), it is straight forward to implement with fsy […]

Done

PS2:

the question is do we really care about the thread creation overhead for something that happens as r […]

To avoid the delay problems, we don't want any write to delay the process. If the thread creation overhead is less than one millisecond, I don't see any problem.

Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/86d11e74_2122bb1d?u... : PS2, Line 10: results

typo: result (without 's')

Done

https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/9cdce0b8_60afcab8?u... : PS2, Line 11: delays

delayed processing causes ... and s/delays/timeouts/? […]

Done

https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/41833c6a_ed45b798?u... : PS2, Line 16: The main process will then output the completion : message on the VTY.

This is no longer true, we decided to log an INFO instead.

Done

File src/vty/command.c:

https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/e687b8df_fd115284?u... : PS2, Line 3413: sync(); : sync_complete(&sync_fd, 0); :

common path for all failing checks, maybe move it down below to the bottom and use `goto`?

Done