Attention is currently required from: fixeria, laforge.

View Change

6 comments:

• Patchset:

  • Patch Set #2:

    If we only care about the new file (not to the backup), it is straight forward to implement with fsy […]

    Done

  • Patch Set #2:

    the question is do we really care about the thread creation overhead for something that happens as r […]

    To avoid the delay problems, we don't want any write to delay the process. If the thread creation overhead is less than one millisecond, I don't see any problem.

• Commit Message:

  • Patch Set #2, Line 10: results

    typo: result (without 's')

    Done

  • Patch Set #2, Line 11: delays

    delayed processing causes ... and s/delays/timeouts/? […]

    Done

  • Patch Set #2, Line 16:

    The main process will then output the completion
    message on the VTY.
    

    This is no longer true, we decided to log an INFO instead.

    Done

• File src/vty/command.c:

  • Patch Set #2, Line 3413:

    		sync();
    		sync_complete(&sync_fd, 0);
    		
    

    common path for all failing checks, maybe move it down below to the bottom and use `goto`?

    Done

To view, visit change 37798. To unsubscribe, or for help writing mail filters, visit settings.