Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 )
Change subject: bsc: Add testscase & infra to validate Osmux support BTS<->BSC
......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/620ed550_d1fe…
PS6, Line 13: sides (towards BTS and CN).
I wonder if in general it makes more sense to not
replace existing tests with different new tests, a […]
IMHO this is not worse than
having extra lines for non-executed tests + having misleading names acording to new state
of things.
File bsc/MSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/22787bf7_4480…
PS6, Line 255: CRCX
MDCX, same 3x below
Ack
File library/RSL_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/4344c19a_1337…
PS6, Line 2310: //tr_RSL_IE_OSMO_Osmux_CID(osmux_cid);
left this intentionally?
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6e82eb9d995de988b812001e1c4cf6923509de66
Gerrit-Change-Number: 29010
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Sep 2022 09:52:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment