Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email )
Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp()
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Ok, maybe best to update the function documentation comment about this notion.
Done in version I just pushed.
File src/tcap_as_loadshare.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210/comment/6e5a47f7_a69616... :
PS1, Line 293: Destination
unrelated: This should actually say "Source Address", it looks like a copy+paste from below
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42214
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c
Gerrit-Change-Number: 42210
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 26 Feb 2026 11:57:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de