Attention is currently required from: falconia, laforge, pespin.
fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email )
Change subject: tests: add trau2rtp_gen program ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File tests/trau_conv/trau2rtp_gen.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/39558/comment/e32d8352_12a80605?... : PS1, Line 150: inv: fprintf(stderr, "%s line %d: invalid syntax\n", infname, lineno);
I made the requested change in Patchset 2. […]
Done
https://gerrit.osmocom.org/c/libosmo-abis/+/39558/comment/32a55d3f_31a54dd5?... : PS1, Line 212: usage: fprintf(stderr, "usage: %s [-8] [-d] [-x] input-file [output-file]\n",
TBH I think it's even the first time I ever saw a goto tag placed into the same line where C code is […]
Is it really worth having a discussion on such a minor coding style detail?
-
fixeria