Attention is currently required from: pespin, fixeria.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30244 )
Change subject: LAPD: move tx_hist code into static functions
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
File src/gsm/lapd_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/30244/comment/d898905a_7847deb7
PS8, Line 1742: {
more should probably unsigned.
The usual story with code review: if I make further changes while restructuring code - somebody will comment that it's unrelated change, if I don't - somebody will comment that further changes would improve things.
To resolve this conundrum let's merge as is and defer improvements to follow-up patches.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30244
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibf3b08c8d874416796b94ba3a672a02d614313b1
Gerrit-Change-Number: 30244
Gerrit-PatchSet: 8
Gerrit-Owner: msuraev
msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: msuraev
msuraev@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Sat, 26 Nov 2022 13:59:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment
msuraev