Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/29660 ) Change subject: mobile: check return value of gsm_arfcn2band_rc() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/host/layer23/src/mobile/gsm322.c: https://gerrit.osmocom.org/c/osmocom-bb/+/29660/comment/9373d952_b670b7ee PS1, Line 4206: if (gsm_arfcn2band_rc(nb->arfcn, &band) != 0) { I think we usually check those as (.. < 0) since negative return indicates error. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia5bc9f8bf4aa3ea7374c67e329db22612bb350ca Gerrit-Change-Number: 29660 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev &lt;msuraev(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Fri, 14 Oct 2022 20:13:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment