Attention is currently required from: arehbein, daniel.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33202 )
Change subject: examples: Add extension header octet to example
......................................................................
Patch Set 12:
(1 comment)
File include/osmocom/netif/ipa.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/33202/comment/0233a971_b0a75c6d
PS12, Line 22: struct msgb *osmo_ipa_ext_msg_alloc(int headroom);
this should imho be a un insigned int headroom or a size_t (yes I know the older API uses
int, but it really makes no sense imho).
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/33202
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I962b9edcba65cdc98da00d2f8753dc5acd481502
Gerrit-Change-Number: 33202
Gerrit-PatchSet: 12
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Jul 2023 10:17:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment