Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27934
)
Change subject: bts: Make sure paging timers are deleted when struct gsm_bts is freed
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27934/comment/0c37d9d4_25e1ac6c
PS1, Line 152: paging_destructor
Is it worth having a function just for two
osmo_timer_del() calls? Are you planning to reuse it? Or […]
I think it really
makes sense to have this function here, since there's an _init() counterpart, and
those timers are always setup and scheduled in this file.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27934
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If8dffc948a3a9d8bdd9237f644e7f10f41c64853
Gerrit-Change-Number: 27934
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Apr 2022 20:17:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment