Attention is currently required from: dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153 )

Change subject: MGCP_Test: support multiple codecs ......................................................................

Patch Set 4: Code-Review+1

(4 comments)

Patchset:

PS4: I expect you did run BTS_Tests/MGCP_Tests/etc. here to validate everything is fine :)

File library/RTP_Emulation.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/be686028_53a9a... PS4, Line 364: private function f_check_fixed_rx_payloads(octetstring rtp_data, INT7b rtp_payload_type) runs on RTP_Emulation_CT { it feels a bit strange having the rtp_Data before the rtp_payload_type, but not criticial.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/857ad355_e0214... PS4, Line 376: if (rtp_data == g_cfg.rx_payloads[i].fixed_payload and rtp_payload_type == g_cfg.rx_payloads[i].payload_type) { split into 2 lines?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32153/comment/3cc0b786_bb722... PS4, Line 388: if (payload_present and payload_error) { This function implementation seem overcmplex with all those bool vars. Why aren't you incrementing the counters in the respective paths in the loop above? it would make everything more simpler afaict.