Attention is currently required from: neels.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092 )
Change subject: bsc: test lchan rel during LCS Loc Req
......................................................................
Patch Set 3: Code-Review+2
(5 comments)
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092/comment/cfefbe25_6950…
PS2, Line 11679: TC_emerg_call_and_lcs_loc_req
Why are you removing this one? Looks like
unintentionally...
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092/comment/0e438b9b_3e4f…
PS2, Line 10304: altstep no_bssmap_clear_req() runs on MSC_ConnHdlr {
'private', unless you want to use this from
other modules.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092/comment/3edfc4bd_93e9…
PS2, Line 10311: type enumerated RslRel {
'private', unless you want to use this from
other modules.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092/comment/68888731_0390…
PS2, Line 10318: 'b7'O
Can we use f_rnd_ra_emerg() here?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092/comment/98579271_12b7…
PS2, Line 10328: isbound
Are you sure it should be isbound() and not
ischosen()?
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idea690a4aa4aecbe4642a16e96d086cc0538564a
Gerrit-Change-Number: 28092
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 May 2022 18:16:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment