laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26852 ) Change subject: icE1usb fw: Update LED status even in E1 FSM is in IDLE state ...................................................................... icE1usb fw: Update LED status even in E1 FSM is in IDLE state Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I82b867c4886c9f34ff685764424d3db9a8303789 --- M firmware/ice40-riscv/icE1usb/e1.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/ice40-riscv/icE1usb/e1.c b/firmware/ice40-riscv/icE1usb/e1.c index 1b6d978..09bc6d2 100644 --- a/firmware/ice40-riscv/icE1usb/e1.c +++ b/firmware/ice40-riscv/icE1usb/e1.c @@ -444,10 +444,6 @@ uint32_t bd; unsigned int ofs; - /* Active ? */ - if ((e1->rx.state == IDLE) && (e1->tx.state == IDLE)) - return; - /* HACK: LED link status */ if (e1_regs->rx.csr & E1_RX_SR_ALIGNED) { e1_platform_led_set(port, E1P_LED_GREEN, E1P_LED_ST_ON); @@ -461,6 +457,10 @@ /* TODO: completely off if rx tick counter not incrementing */ } + /* Active ? */ + if ((e1->rx.state == IDLE) && (e1->tx.state == IDLE)) + return; + /* Recover any done TX BD */ while ( (bd = e1_regs->tx.bd) & E1_BD_VALID ) { e1f_multiframe_read_discard(&e1->tx.fifo); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26852 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I82b867c4886c9f34ff685764424d3db9a8303789 Gerrit-Change-Number: 26852 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged