Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31544 ) Change subject: codec_pref: split test_codec_support_bts_rate ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/codec_pref.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31544/comment/7d7596b4_cb1af3b7 PS1, Line 211: if (rc < 0 || !test_codec_support_bts_rate(bts, full_rate)) this looks a bit weird/condensed, you could split it into 2 ifs like it was before. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iea8a23ef3c66ed556110038fe9f3bc7f6eef3e96 Gerrit-Change-Number: 31544 Gerrit-PatchSet: 1 Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Comment-Date: Mon, 27 Feb 2023 17:05:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment