Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email )
Change subject: sccp: Introduce initial support for SCCP LUDT + LUDTS messages
......................................................................
Patch Set 3:
(1 comment)
File include/osmocom/sccp/sccp_types.h:
https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/fef22539_c68dfba8
PS2, Line 505: #if VARIABLE
I see that this is elsewhere in the file too, but
being curious: are the "if VARIABLE" and "if OPTIO […]
Yeah I think
so, I also was a bit confused. I simply followed the existing code here...
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ic91abfc921f5e4f36045bfa325333112cddd9fa6
Gerrit-Change-Number: 34467
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Sep 2023 08:52:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment