[S] Change in libosmo-sccp[master]: Set stream_cli/srv name to contain ASP + sockname - gerrit-log

17 Jun 2023


      Attention is currently required from: pespin, daniel.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33335 )
Change subject: Set stream_cli/srv name to contain ASP + sockname
......................................................................
Patch Set 5:
(1 comment)
File src/osmo_ss7.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/33335/comment/54ab0641_006d6728 
PS5, Line 2102: ,%
I think that comma may later end up in FSM names which might in turn get exported via CTRL or counters, which in turn don't support anything that doesn't pass osmo_identifier_valid, so it might either break someting or get escaped.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33335
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I05bc5f6c7795f62c1814c1c774287b41ee85a475
Gerrit-Change-Number: 33335
Gerrit-PatchSet: 5
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Sat, 17 Jun 2023 06:03:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment