Attention is currently required from: pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/30279 ) Change subject: gtp: Introduce VTY configurable GTP timer X3 ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: maybe the timer number needs to be changed, otherwise LGTM File gtp/gsn.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/30279/comment/2770e114_1dd72819 PS1, Line 70: GTP_GSN_TIMER_T3_HOLD_RESPONSE = -3, Neels told me, we try to keep timer numbers unique in Osmocom. Use a number that isn't used yet and add it here? https://osmocom.org/projects/cellular-infrastructure/wiki/List_of_Timer_num… -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/30279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ia15c1cfd201d7c43e9a1d6ceb6725ddf392d2c65 Gerrit-Change-Number: 30279 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Nov 2022 11:53:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment