Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29752 )
Change subject: SNDCP: add LLE-specific logging wrapper ......................................................................
Patch Set 4:
(1 comment)
File src/sgsn/gprs_sndcp.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/29752/comment/34d3dbf4_9490f12d PS4, Line 225: (LLE)->llme->tlli, (LLE)->sapi, (NSAPI), llist_count(&gprs_sndcp_entities), ##ARGS)
Counting list only when we need to log some error (which is most of the cases in the patch) is way b […]
I don't see this macro using LOGL_ERROR, but a LEVEL field, which means will be used for any logging. Is it really needed to prit the count on every log? Leaving to others to provide opinion on the topic.