Attention is currently required from: msuraev.

View Change

1 comment:

• File src/sgsn/gprs_sndcp.c:

  • Patch Set #4, Line 225: (LLE)->llme->tlli, (LLE)->sapi, (NSAPI), llist_count(&gprs_sndcp_entities), ##ARGS)

    Counting list only when we need to log some error (which is most of the cases in the patch) is way b […]

    I don't see this macro using LOGL_ERROR, but a LEVEL field, which means will be used for any logging. Is it really needed to prit the count on every log?
    Leaving to others to provide opinion on the topic.

To view, visit change 29752. To unsubscribe, or for help writing mail filters, visit settings.