Attention is currently required from: jolly, laforge.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email )
Change subject: Add multiple messages buffers to struct iofd_msghdr
......................................................................
Patch Set 6:
(1 comment)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/87e01b65_5f7fd98d?u... :
PS3, Line 406: struct msgb *msg = msghdr->msg[0];
why is this and below always [0]?
I see now, because this commit is actually not yet adding support for >1 msgb per msghdr, it's only an intermediate preparation. Please state so in the commit description.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4fb1067de4615cc22cc6caf99b481491e7f2ef92
Gerrit-Change-Number: 40491
Gerrit-PatchSet: 6
Gerrit-Owner: jolly
andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Comment-Date: Wed, 23 Jul 2025 15:06:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de