Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38301?usp=email )

Change subject: csd_v110: properly set bit E2 for TCH/F4.8 NT ......................................................................

Patch Set 1:

(2 comments)

File src/common/csd_v110.c:

https://gerrit.osmocom.org/c/osmo-bts/+/38301/comment/fa9aeeda_589d3438?usp=... : PS1, Line 113: if ((i & 1) == 0) { /* executed for Q1/Q3 */ we usually use hex notation to do bitmask. (i & 0x01) == 0x00

https://gerrit.osmocom.org/c/osmo-bts/+/38301/comment/4b6b2e6b_3f9c79cd?usp=... : PS1, Line 125: * Q4 | =1 | =1 for i=3 (0x03, 0b00000011), AFAIU you don't enter here, so you use "e2_bit = 0" at the start of the function which seems to not match Q4 in the table above?