Attention is currently required from: fixeria.

View Change

2 comments:

• File src/common/csd_v110.c:

  • Patch Set #1, Line 113: if ((i & 1) == 0) { /* executed for Q1/Q3 */

    we usually use hex notation to do bitmask.
    (i & 0x01) == 0x00

  • Patch Set #1, Line 125: * Q4 | =1 | =1

    for i=3 (0x03, 0b00000011), AFAIU you don't enter here, so you use "e2_bit = 0" at the start of the function which seems to not match Q4 in the table above?

To view, visit change 38301. To unsubscribe, or for help writing mail filters, visit settings.