Attention is currently required from: laforge.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586?usp=email )

Change subject: vty: Make sure user doesn't configure AS in ASP role with a non-local PC as routing-key ......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/40586/comment/22f07826_fd34ba... : PS1, Line 9: AS

well, it's not what the RFC authors had in mind, for sure. […]

If the AS(P) of one of the STPs is configured with role ASP, then yeah we may want to configure there using a remote PC.

We also have a global "enum cs7_role_t cs7_role" which we set based on call to osmo_ss7_vty_init_asp() or osmo_ss7_vty_init_sg(). I'll add that into the logic check so that the validation is only done when global cs7_role = CS7_ROLE_ASP.