Attention is currently required from: daniel, jolly.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35909?usp=email )
Change subject: osmo_io: Move notify_connected function to backend
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
File src/core/osmo_io_poll.c:
https://gerrit.osmocom.org/c/libosmocore/+/35909/comment/8648f276_ad8ac1e3
PS2, Line 115: if (osmo_fd_is_registered(ofd))
This is expensive!!!
See how osmo_fd_register() doesn't call osmo_fd_is_registered unless
"--enable-ofd-check" is passed for debugging purposes.
https://gerrit.osmocom.org/c/libosmocore/+/35909/comment/fc25a509_79b0d19f
PS2, Line 125: if (!osmo_fd_is_registered(ofd))
This is expensive!!!
See how osmo_fd_register() doesn't call osmo_fd_is_registered unless
"--enable-ofd-check" is passed for debugging purposes.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35909?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I905ec85210570aff8addadfc9603335d04eb057a
Gerrit-Change-Number: 35909
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Feb 2024 10:07:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment