Change in libosmocore[master]: logging: do not expose internal data structures - gerrit-log

15 Dec 2022


      Attention is currently required from: Hoernchen.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30609 )
Change subject: logging: do not expose internal data structures
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
File include/osmocom/core/logging.h:
https://gerrit.osmocom.org/c/libosmocore/+/30609/comment/9d0aa7d8_8e9e5338 
PS1, Line 14: extern struct log_info *osmo_log_info;
osmo_log_info is how logging_vty.c knows about logging config. How did you adjust for that?
Changing public API is a problem, we need to keep this publicly accessible simply because it was public API before, in order to guarantee backwards compat in API.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30609
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2ba3506233ff485f3935b2f46c94d8351b5d283c
Gerrit-Change-Number: 30609
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Attention: Hoernchen ewild@sysmocom.de
Gerrit-Comment-Date: Thu, 15 Dec 2022 02:29:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment