Attention is currently required from: fixeria. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Vadim, thanks for feedback. There are drawbacks of both approaches: if we do it earlier in the patchset, then faketrx cannot work without cython at all. However this fix does not require cython and can be done in pure python. It brings significant benefit just by itself, but unfortunately that speedup is not enough. Overall the problem here is similar to bootstrapping: you cannot really do via single-step without braking something: do single step in plain py - we break compatibility with py < 3.13. Do single step with upgrading to cython: we break compatibility with current tests because they all do currently fail as it is not programmed there to build fake_trx before running it. I choosed to do this step in plain py without bringing cython yet, because it looks more logical to me to fix this while being at plain py level. Reworking the patches to bring cython earlier would be alot of internal inter-patch churn without, in my view, strong benefit. I would appreciate if we can leave the order of steps as they are currently. Kirill P.S. However one thing that could be maybe possible to maybe do is to merge the patch of pyx timerfd right after switch to cython. Then the time where fake_trx becomes py3.13-only will be limited. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr &lt;kirr(a)nexedi.com&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Fri, 18 Apr 2025 08:12:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr &lt;kirr(a)nexedi.com&gt; Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;