Attention is currently required from: daniel, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email )
Change subject: osmo_io: Support rx of segments up to ~UINT16_MAX ......................................................................
Patch Set 5:
(4 comments)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/8ae344fe_09cba592?u... : PS5, Line 367: struct osmo_io_fd *iofd `const`
https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/ad530c95_d3f1eddd?u... : PS5, Line 379: memcpy(msgb_put(iofd->pending, msgb_length(in_msg)), : msgb_data(in_msg), : cosmetic: formatting looks weird here, I find it confusing
File tests/osmo_io/osmo_io_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/c4bb923d_fbb13aac?u... : PS5, Line 413: 3 ```suggestion for (unsigned int i = 0; i < num_write_msgs; i++) { ```
https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/cfad80c8_cfe3a4d8?u... : PS5, Line 513: ; ```suggestion for (unsigned int i = 0; i < num_write_msgs; i++) { ```