Attention is currently required from: osmith, laforge, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28166 )
Change subject: coding: fix decoding of AHS_SID_UPDATE frames (BER ~50%)
......................................................................
Patch Set 4:
(1 comment)
File src/coding/gsm0503_coding.c:
https://gerrit.osmocom.org/c/libosmocore/+/28166/comment/24a50d01_f25036c2
PS4, Line 2684: AHS_SID_UPDATE
AHS_SID_UPDATE is handled below now, remove it from the TODO?
This comment is about a combination of AHS_SID_UPDATE and AHS_SID_UPDATE_INH. They can be interleaved together to indicate that the DTX pause is over and speech frames follow. Implementing (or at least testing) this would require some additional time budget.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28166
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8686d895e96fa0e606c1898b6574cc80a8f46983
Gerrit-Change-Number: 28166
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Mon, 23 May 2022 09:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith
osmith@sysmocom.de
Gerrit-MessageType: comment
fixeria