fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38428?usp=email ) Change subject: diameter: assert that diameter:start_service/2 returns ok ...................................................................... diameter: assert that diameter:start_service/2 returns ok I introduced a regression in 1545311, which would have been spotted much earlier if we had such an assertion in place. Add it. Change-Id: Ief13353d280e3eb80a25b5c9a9effdf537bcc704 Related: 1545311 "diameter: fix unused macro param in ?SERVICE" --- M src/osmo_dia2gsup.erl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index 26376a4..b8d7a34 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -97,7 +97,7 @@ init(State) -> % DIAMETER side ProdName = atom_to_list(?MODULE), - diameter:start_service(?SVC_NAME, ?SERVICE(ProdName)), + ok = diameter:start_service(?SVC_NAME, ?SERVICE(ProdName)), Ip = application:get_env(osmo_dia2gsup, diameter_ip, "127.0.0.8"), Port = application:get_env(osmo_dia2gsup, diameter_port, 3868), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ief13353d280e3eb80a25b5c9a9effdf537bcc704 Gerrit-Change-Number: 38428 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>