Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28669 )
Change subject: trxcon: rework L1CTL socket API to support multiple clients ......................................................................
Patch Set 5:
(1 comment)
File src/host/trxcon/src/l1ctl_link.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/2e77e475_89dbe046 PS5, Line 223: osmo_fd_setup(&server->ofd, -1, OSMO_FD_READ, &l1ctl_server_conn_cb, server, 0);
passing "func" vs "&func". I see all code in osmocom passing "func".
There is no difference between func and &func, it's just a matter of taste. I prefer &func, because this makes it explicit that I want a function pointer, and did not just forget to call the function.