[S] Change in osmo-ttcn3-hacks[master]: S1AP_Templates: fix tr_S1AP_SetupReq - gerrit-log

9 Jul 2023


      Attention is currently required from: laforge, pespin, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33633 )
Change subject: S1AP_Templates: fix tr_S1AP_SetupReq
......................................................................
Patch Set 1:
(1 comment)
File library/s1ap/S1AP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33633/comment/8bdd7333_86ffb... 
PS1, Line 72: 					}, *, {
...
There is only one IE in between, the `eNB Name`. So yes, it should be `?`.
... but this IE is defined as optional, so `?` is not the correct option. Does `ifpresent` work within template lists? IIRC, no. So using `*` seems to be the only option :/
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33633
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id4b52921053884e79349301598b75c264b7f058c
Gerrit-Change-Number: 33633
Gerrit-PatchSet: 1
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Sun, 09 Jul 2023 11:32:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment