Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email )
Change subject: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
File library/RAW_NS.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/6dfbd976_fce3…
:
PS3, Line 512: istemplatekind(cause, "*"))
This is impossible because the template restriction of the function argument is `(omit)`,
meaning that it can only be a value or `omit` (you'll get a DTE if you pass `*`).
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/55d36335_2d3f…
:
PS3, Line 524: istemplatekind(cause, "*"))
Same here.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102
Gerrit-Change-Number: 39063
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 10 Dec 2024 07:50:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes