[L] Change in libosmo-netif[master]: Add osmo_io support to osmo_stream_cli and osmo_stream_srv - gerrit-log

7 Jun 2023

Attention is currently required from: arehbein, laforge.

daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33193 )

Change subject: Add osmo_io support to osmo_stream_cli and osmo_stream_srv
......................................................................

Patch Set 2:

(9 comments)

File src/stream.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/1da4dd89_20127176 
PS1, Line 367: ;
...
  I'd go for EINVAL here. […] Done

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/acc5bda2_a4fe8a58 
PS1, Line 602: done
...
  I'd usually say that it is "established"
after connect succeeds? Sounds better. I'll also change it in the old code (some
of the other changes as well)

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/e322b281_5a1fda36 
PS1, Line 654: error %d to send
...
  sounds a bit like we are "about to send ... as an
error". […] Ack

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/516d05ca_95160fd6 
PS1, Line 683: osmo_iofd_setup
...
  osmo_iofd_setup may return NULL. missing error
handling. Ack

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/e9ca1334_36a551ce 
PS1, Line 1715: LOGL_DEBUG
...
  this message might be worth INFO or even NOTICE, I
think. Done

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/a1771984_924a533b 
PS1, Line 1758: OSMO_ASSERT
...
  why is this commented out?  Is the idea to permit a
srv_link in ofd mode and the stream_srv in osmo_ […] Wow, I just saw that
osmo_stream_srv_link_create_iofd() is a 100% copy of the old variant.
I would say I just remove that version - I'm not sure what we gain handling accept()
with osmo_io.

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/0a30963b_955d7cee 
PS1, Line 1762: 		LOGP(DLINP, LOGL_ER
...
  if the memory allocator fails, it's always an
ENOMEM situation, so it's not realyl worth calling str […] Ack, removing it in
osmo_stream_srv_create() as well.

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/ffb73b81_4d67635e 
PS1, Line 1768: osmo_iofd_setup
...
  osmo_iofd_setup may return NULL. […] Ack

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/f82406a7_e513862c 
PS1, Line 1775: talloc_free
...
  is there nothing we need to call to undo whatever
osmo_iofd_setup() has done above? No, it simply allocates memory and fills in the
struct. Everything else is done in osmo_iofd_register()

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33193
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2f52c7107c392b6f4b0bf2a84f8c873c084a200c
Gerrit-Change-Number: 33193
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein &lt;arehbein(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: arehbein &lt;arehbein(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Comment-Date: Wed, 07 Jun 2023 15:49:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-MessageType: comment