Attention is currently required from: falconia, laforge.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email )
Change subject: tests: add trau2rtp_gen program ......................................................................
Patch Set 2:
(1 comment)
File tests/trau_conv/trau2rtp_gen.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/39558/comment/35de0a72_96abad99?... : PS1, Line 212: usage: fprintf(stderr, "usage: %s [-8] [-d] [-x] input-file [output-file]\n",
Your forgot this one
TBH I think it's even the first time I ever saw a goto tag placed into the same line where C code is, I didn't even think about it being possible (but yeah, from asm PoV it makes sense). It personally created some disruption to me while looking at the code, hence why I shared. If other are fine with having this inline then fine with merging is this way.
-
pespin