Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28483 )
Change subject: mgcp-client: Avoid string not null terminated access ......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/28483/comment/15c4b51a_190325bb PS1, Line 732: /* EOS char to avoid out-of-buf str access, not part of the msg: */ mgcp_client_rx() calls mgcp_response_parse_head(), which in its turn calls mgcp_msg_terminate_nul(). Are you sure adding '\0' is really needed here?