Attention is currently required from: arehbein, fixeria, jolly, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email )
Change subject: osmo_io: SCTP support
......................................................................
Patch Set 7:
(1 comment)
File include/osmocom/core/osmo_io.h:
https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/9b4e3afc_1811364c
PS3, Line 17: // FIXME: This must avoid clashing with the existing definitions in libosmo-netif!!!
did this clash disappear magically?
I explicitly requested somewhere (review comment or redmine issue) to test build all osmocom software to see if the clash ever appears in practice. It seems it hasnt? Would be good to get explicit confirmation from jolly.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I89eb519b22d21011d61a7855b2364bc3c295df82
Gerrit-Change-Number: 35068
Gerrit-PatchSet: 7
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein
arehbein@sysmocom.de
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: jolly
andreas@eversberg.eu
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: arehbein
arehbein@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 20 Feb 2024 19:10:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment
laforge