[M] Change in osmocom-bb[master]: trx_toolkit/*: Represent bursts as arrays instead of lists - gerrit-log

25 Feb 2025


      Attention is currently required from: kirr.
fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39536?usp=email )
Change subject: trx_toolkit/*: Represent bursts as arrays instead of lists
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/target/trx_toolkit/data_msg.py:
https://gerrit.osmocom.org/c/osmocom-bb/+/39536/comment/cc80fd36_4bd0a373?us... :
PS2, Line 31: struct.unpack('b', struct.pack('B', x))[0]
Alternatively, we could use `int.to_bytes()` / `int.from_bytes()` API here:
```
return int.from_bytes(x.to_bytes(1), signed=True)
```
No idea if it's better or worse in terms of performance though.
-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39536?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7314e9e79752e06fa86b9e346a9beacc5e59579e
Gerrit-Change-Number: 39536
Gerrit-PatchSet: 2
Gerrit-Owner: kirr kirr@nexedi.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: osmith osmith@sysmocom.de
Gerrit-Attention: kirr kirr@nexedi.com
Gerrit-Comment-Date: Tue, 25 Feb 2025 10:03:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes