Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40970?usp=email )
Change subject: testenv: fix missing hasattr check
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File _testenv/testenv/__init__.py:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40970/comment/6e066386_9fda…
:
PS1, Line 282: if hasattr(args, "distro") and args.distro is None:
Maybe do `getattr(args, "distro", None) is
None` here?
Ah, my proposal is actually wrong. Nevermind.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40970?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I138fda5f5807588428bba4eb1593b887fe7357c9
Gerrit-Change-Number: 40970
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Aug 2025 20:03:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>