Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email ) Change subject: add fw update crcstub ...................................................................... Patch Set 10: (2 comments) File crc_code.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/b2cc03d1_b5bbad5… : PS10, Line 102: // uint32_t length = strtoul(argv[3], NULL, 16); can this commented out code be removed? I guess every C developer knows that diferent base arguments can be given to strtoul, if so desired? File crc_params.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/e8138594_0a61bc3… : PS10, Line 5: // __attribute__((used, section(".crc_par"))) const uint32_t __CRC_End = 0xFFFFFFFF; /* Placeholder */ why do we have this commented-out code here? is this some earlier attempts? shouldn't it be removed? -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed Gerrit-Change-Number: 39437 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Feb 2025 09:30:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No