Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/33620 ) Change subject: aarch64: add get_cycles ...................................................................... Patch Set 1: (2 comments) File include/osmocom/gapk/get_cycles.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9067): https://gerrit.osmocom.org/c/gapk/+/33620/comment/1bd0fc91_c4f34db5 PS1, Line 108: typedef unsigned long cycles_t; do not add new typedefs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9067): https://gerrit.osmocom.org/c/gapk/+/33620/comment/879ee11b_c69a72d9 PS1, Line 109: static inline cycles_t get_cycles() Bad function definition - cycles_t get_cycles() should probably be cycles_t get_cycles(void) -- To view, visit https://gerrit.osmocom.org/c/gapk/+/33620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I489fb8346fbc7440f40695f01d80a89b90761165 Gerrit-Change-Number: 33620 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jul 2023 15:08:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment