Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email ) Change subject: ASCI: Add group receive and transmit mode support to MM layer ...................................................................... Patch Set 1: (4 comments) File src/host/layer23/src/mobile/gsm48_mm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11171): https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/c83585cb_7a20f258 PS1, Line 277: * completely independant from the state of the MM layer. 'independant' may be misspelled - perhaps 'independent'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11171): https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/ccc37e3f_ad5f5bb6 PS1, Line 3822: msg_type = (mm->vgcs_group_call) ? GSM48_MMGCC_GROUP_CNF: GSM48_MMBCC_GROUP_CNF; spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11171): https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/99c5b470_08d4b251 PS1, Line 3967: msg_type = (mm->vgcs_group_call) ? GSM48_MMGCC_UPLINK_CNF: GSM48_MMBCC_UPLINK_CNF; spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11171): https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/422042c4_38c79d66 PS1, Line 3993: msg_type = (mm->vgcs_group_call) ? GSM48_MMGCC_UPLINK_REL_IND: GSM48_MMBCC_UPLINK_REL_IND; spaces required around that ':' (ctx:VxW) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I05957182a57423ad947ab200b52f65fde859e110 Gerrit-Change-Number: 34492 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 21 Sep 2023 09:39:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment