laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35818?usp=email ) Change subject: pylint: cat.py ...................................................................... pylint: cat.py pySim/cat.py:586:4: W0237: Parameter 'do' has been renamed to 'x' in overriding 'PlmnWactList._from_bytes' method (arguments-renamed) pySim/cat.py:981:8: W0120: Else clause on loop without a break statement, remove the else and de-indent all the code inside it (useless-else-on-loop) pySim/cat.py:1000:4: W0221: Number of parameters was 3 in 'TLV_IE_Collection.from_bytes' and is now 2 in overriding 'ProactiveCommand.from_bytes' method (arguments-differ) pySim/cat.py:1010:12: W0612: Unused variable 'dec' (unused-variable) pySim/cat.py:1010:17: W0612: Unused variable 'remainder' (unused-variable) pySim/cat.py:1022:4: W0221: Number of parameters was 2 in 'TLV_IE_Collection.to_bytes' and is now 1 in overriding 'ProactiveCommand.to_bytes' method (arguments-differ) pySim/cat.py:22:0: C0411: standard import "from typing import List" should be placed before "from bidict import bidict" (wrong-import-order) pySim/cat.py:26:0: C0411: third party import "from construct import Int8ub, Int16ub, Byte, Bytes, Bit, Flag, BitsInteger" should be placed before "from pySim.utils import b2h, h2b, dec_xplmn_w_act" (wrong-import-order) pySim/cat.py:27:0: C0411: third party import "from construct import Struct, Enum, Tell, BitStruct, this, Padding, RepeatUntil" should be placed before "from pySim.utils import b2h, h2b, dec_xplmn_w_act" (wrong-import-order) pySim/cat.py:28:0: C0411: third party import "from construct import GreedyBytes, Switch, GreedyRange, FlagsEnum" should be placed before "from pySim.utils import b2h, h2b, dec_xplmn_w_act" (wrong-import-order) pySim/cat.py:23:0: W0611: Unused h2b imported from pySim.utils (unused-import) pySim/cat.py:26:0: W0611: Unused Bit imported from construct (unused-import) pySim/cat.py:26:0: W0611: Unused Flag imported from construct (unused-import) pySim/cat.py:27:0: W0611: Unused Tell imported from construct (unused-import) pySim/cat.py:27:0: W0611: Unused Padding imported from construct (unused-import) pySim/cat.py:27:0: W0611: Unused RepeatUntil imported from construct (unused-import) Change-Id: I0c6327a7a8045736e8678b7286a7ed685c96fb71 --- M pySim/cat.py 1 file changed, 39 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/18/35818/1 diff --git a/pySim/cat.py b/pySim/cat.py index 5925bf3..1dff194 100644 --- a/pySim/cat.py +++ b/pySim/cat.py @@ -18,14 +18,14 @@ # along with this program. If not, see <http://www.gnu.org/licenses/>. -from bidict import bidict from typing import List -from pySim.utils import b2h, h2b, dec_xplmn_w_act +from bidict import bidict +from construct import Int8ub, Int16ub, Byte, Bytes, BitsInteger +from construct import Struct, Enum, BitStruct, this +from construct import GreedyBytes, Switch, GreedyRange, FlagsEnum from pySim.tlv import TLV_IE, COMPR_TLV_IE, BER_TLV_IE, TLV_IE_Collection from pySim.construct import PlmnAdapter, BcdAdapter, HexAdapter, GsmStringAdapter, TonNpi -from construct import Int8ub, Int16ub, Byte, Bytes, Bit, Flag, BitsInteger -from construct import Struct, Enum, Tell, BitStruct, this, Padding, RepeatUntil -from construct import GreedyBytes, Switch, GreedyRange, FlagsEnum +from pySim.utils import b2h, dec_xplmn_w_act # Tag values as per TS 101 220 Table 7.23 @@ -583,11 +583,11 @@ # TS 31.111 Section 8.90 class PlmnWactList(COMPR_TLV_IE, tag=0xF2): - def _from_bytes(self, x): + def _from_bytes(self, do: bytes): r = [] i = 0 - while i < len(x): - r.append(dec_xplmn_w_act(b2h(x[i:i+5]))) + while i < len(do): + r.append(dec_xplmn_w_act(b2h(do[i:i+5]))) i += 5 return r @@ -978,8 +978,8 @@ for c in self.children: if type(c).__name__ == 'CommandDetails': return c - else: - return None + else: + return None class ProactiveCommand(TLV_IE_Collection, nested=[Refresh, MoreTime, PollInterval, PollingOff, SetUpEventList, SetUpCall, @@ -997,7 +997,7 @@ more difficult than any normal TLV IE Collection, because the content of one of the IEs defines the definitions of all the other IEs. So we first need to find the CommandDetails, and then parse according to the command type indicated in that IE data.""" - def from_bytes(self, binary: bytes) -> List[TLV_IE]: + def from_bytes(self, binary: bytes, context: dict = {}) -> List[TLV_IE]: # do a first parse step to get the CommandDetails pcmd = ProactiveCommandBase() pcmd.from_tlv(binary) @@ -1007,7 +1007,7 @@ if cmd_type in self.members_by_tag: cls = self.members_by_tag[cmd_type] inst = cls() - dec, remainder = inst.from_tlv(binary) + _dec, remainder = inst.from_tlv(binary) self.decoded = inst else: self.decoded = pcmd @@ -1019,7 +1019,7 @@ def to_dict(self): return self.decoded.to_dict() - def to_bytes(self): + def to_bytes(self, context: dict = {}): return self.decoded.to_tlv() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0c6327a7a8045736e8678b7286a7ed685c96fb71 Gerrit-Change-Number: 35818 Gerrit-PatchSet: 1 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-MessageType: newchange