laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36523?usp=email )
Change subject: hnbgw: Use "NAS/Normal" as default release cause ......................................................................
hnbgw: Use "NAS/Normal" as default release cause
We shouldn't run all of our tests with a rather exotic release cause value (O&M intervention) but assume a normal/orderly NAS triggered release, unless a specific test case explicitly tests an abnormal release cause.
Change-Id: I8ddd1dccc5637431e3a8c6e607e0e45faa82b5b5 --- M hnbgw/HNBGW_Tests.ttcn M library/ranap/RANAP_Templates.ttcn 2 files changed, 18 insertions(+), 2 deletions(-)
Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified
diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 518dee9..808db75 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1054,7 +1054,7 @@ private template (value) TestHdlrParams t_pars(integer imsi_suffix, boolean ps_domain := false, integer hnb_idx := 0, boolean expect_separate_sccp_cr := false, integer tx_sccp_cr_data_len := 0, - integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_om_intervention) := { + integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_nas_normal) := { hnb_idx := hnb_idx, cn_idx := f_cn_idx(ps_domain, cn_nr), imsi := f_gen_imsi(imsi_suffix), @@ -1477,7 +1477,7 @@ g_num_hnbs := 1; f_init();
- vc_conn := f_start_handler_with_pars(refers(f_tc_rab_assign_fail), t_pars(4)); + vc_conn := f_start_handler_with_pars(refers(f_tc_rab_assign_fail), t_pars(4, rab_rel_cause := ts_RanapCause_radio_conn_lost)); vc_conn.done;
f_shutdown_helper(); diff --git a/library/ranap/RANAP_Templates.ttcn b/library/ranap/RANAP_Templates.ttcn index 018cb81..8e6c8f3 100644 --- a/library/ranap/RANAP_Templates.ttcn +++ b/library/ranap/RANAP_Templates.ttcn @@ -12,6 +12,8 @@ import from RANAP_PDU_Descriptions all;
template (value) Cause ts_RanapCause_om_intervention := { misc := 113 }; +template (value) Cause ts_RanapCause_nas_normal := { nAS := 83 }; +template (value) Cause ts_RanapCause_radio_conn_lost := { radioNetwork := 46 };
/***************************************************************************************************** * Reset