pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26898 )
Change subject: iu_client: Fix incorrect access to null pointer ......................................................................
iu_client: Fix incorrect access to null pointer
Fixes: adec82f3b1c725e8a70d327b9592940fbdeaaff7 Closes: Coverity CID#243765 Related: OS#5398 Change-Id: Ib435b053241c294619c3478fe3b6450d8d181888 --- M src/iu_client.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/98/26898/1
diff --git a/src/iu_client.c b/src/iu_client.c index 7d29903..077ac27 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -462,8 +462,7 @@ struct osmo_scu_prim *prim;
if (!uectx) { - LOGPIU(LOGL_ERROR, "Discarding to-be-transmitted L3 Message as RANAP DT with unset dst SCCP conn_id!\n", - uectx->conn_id); + LOGPIU(LOGL_ERROR, "Discarding to-be-transmitted L3 Message as RANAP DT with unset dst SCCP conn_id!\n"); return -ENOTCONN; }
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26898 )
Change subject: iu_client: Fix incorrect access to null pointer ......................................................................
Patch Set 1:
I'll merge this myself since it's an stupid trivial error I introduced in a recent patch while attempting the same null pointer access...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26898 )
Change subject: iu_client: Fix incorrect access to null pointer ......................................................................
Patch Set 1: Code-Review+2
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26898 )
Change subject: iu_client: Fix incorrect access to null pointer ......................................................................
iu_client: Fix incorrect access to null pointer
Fixes: adec82f3b1c725e8a70d327b9592940fbdeaaff7 Closes: Coverity CID#243765 Related: OS#5398 Change-Id: Ib435b053241c294619c3478fe3b6450d8d181888 --- M src/iu_client.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved
diff --git a/src/iu_client.c b/src/iu_client.c index 7d29903..077ac27 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -462,8 +462,7 @@ struct osmo_scu_prim *prim;
if (!uectx) { - LOGPIU(LOGL_ERROR, "Discarding to-be-transmitted L3 Message as RANAP DT with unset dst SCCP conn_id!\n", - uectx->conn_id); + LOGPIU(LOGL_ERROR, "Discarding to-be-transmitted L3 Message as RANAP DT with unset dst SCCP conn_id!\n"); return -ENOTCONN; }
-
pespin