Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29725 ) Change subject: osmux: Clean up mgcp_config osmux fields ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: I'd add indentation for the struct, otherwise LGTM File include/osmocom/mgcp/mgcp.h: https://gerrit.osmocom.org/c/osmo-mgw/+/29725/comment/c7e4eeb7_d25ad70b PS1, Line 162: enum osmux_usage usage; no indentation for contents of the struct? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icc1c1ce3ab3a8beb941cda7c112485a0db882a90 Gerrit-Change-Number: 29725 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Oct 2022 08:42:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment