Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email ) Change subject: DIAMETER_Types: Generate types for 3GPP TS 29.273 ...................................................................... Patch Set 1: (36 comments) File library/DIAMETER_Types.ttcn: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/40468ccd_4976… PS1, Line 1821: // Dependant applications 'Dependant' may be misspelled - perhaps 'Dependent'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/8d113e68_4552… PS1, Line 1832: type AVP_Grouped AAA_3GPP_Non_3GPP_User_Data trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/e07425e6_6dde… PS1, Line 1869: type AVP_UTF8String AAA_3GPP_ANID trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/6a1a2272_e926… PS1, Line 1873: type AVP_Grouped AAA_3GPP_Trace_Info trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/08b7bc4d_cf0d… PS1, Line 1877: type AVP_OctetString AAA_3GPP_MIP_FA_RK trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/21005e2d_a6a2… PS1, Line 1881: type AVP_Unsigned32 AAA_3GPP_MIP_FA_RK_SPI trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/d40df8ed_b394… PS1, Line 1885: type AVP_Unsigned32 AAA_3GPP_PPR_Flags trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/e23d9418_09fe… PS1, Line 1889: type AVP_Grouped AAA_3GPP_WLAN_Identifier trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/14c5d19d_f806… PS1, Line 1893: type AVP_Grouped AAA_3GPP_TWAN_Access_Info trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/bd595ba2_d0e7… PS1, Line 1897: type AVP_Unsigned32 AAA_3GPP_Access_Authorization_Flags trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/c177361e_f635… PS1, Line 1901: type AVP_Unsigned32 AAA_3GPP_TWAN_Default_APN_Context_Id trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/87abfb17_ce9a… PS1, Line 1915: type AVP_OctetString AAA_3GPP_Full_Network_Name trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/67ebde4f_a362… PS1, Line 1919: type AVP_OctetString AAA_3GPP_Short_Network_Name trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/273b763b_52bc… PS1, Line 1923: type AVP_Unsigned32 AAA_3GPP_AAA_Failure_Indication trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/27e14ff3_33ed… PS1, Line 1937: type AVP_Unsigned32 AAA_3GPP_DER_Flags trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/38282507_204b… PS1, Line 1941: type AVP_Unsigned32 AAA_3GPP_DEA_Flags trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/f6bf5465_5e50… PS1, Line 1945: type AVP_Unsigned32 AAA_3GPP_RAR_Flags trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/414d75cb_415b… PS1, Line 1949: type AVP_Unsigned32 AAA_3GPP_DER_S6b_Flags trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/1fa43b5b_0112… PS1, Line 1953: type AVP_UTF8String AAA_3GPP_SSID trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/9c84c94e_c625… PS1, Line 1957: type AVP_UTF8String AAA_3GPP_HESSID trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/18d7ef3e_90a9… PS1, Line 1962: type AVP_Grouped AAA_3GPP_Access_Network_Info trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/5a6f7c3f_8588… PS1, Line 1966: type AVP_Unsigned32 AAA_3GPP_TWAN_Connection_Mode trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/adc2f8e9_83e8… PS1, Line 1970: type AVP_Grouped AAA_3GPP_TWAN_Connectivity_Parameters trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/670849ae_c8f0… PS1, Line 1974: type AVP_Unsigned32 AAA_3GPP_Connectivity_Flags trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/81a7021e_bb39… PS1, Line 1978: type AVP_Grouped AAA_3GPP_TWAN_PCO trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/4aeb0bf8_daf1… PS1, Line 1982: type AVP_Address AAA_3GPP_TWAG_CP_Address trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/bac104d4_1dc5… PS1, Line 1986: type AVP_UTF8String AAA_3GPP_TWAG_UP_Address trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/7c2bc73f_fc0a… PS1, Line 1990: type AVP_Unsigned32 AAA_3GPP_TWAN_S2a_Failure_Cause trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/7072853c_c41e… PS1, Line 1994: type AVP_Unsigned32 AAA_3GPP_SM_Back_Off_Timer trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/edbc7be2_7da1… PS1, Line 1998: type AVP_OctetString AAA_3GPP_WLCP_Key trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/82e99c66_57e2… PS1, Line 2002: type AVP_Unsigned64 AAA_3GPP_Origination_Time_Stamp trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/8459c204_e283… PS1, Line 2006: type AVP_Unsigned32 AAA_3GPP_Maximum_Wait_Time trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/d6d37e1f_ddc8… PS1, Line 2010: type AVP_Unsigned32 AAA_3GPP_Emergency_Services trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/060fd0f1_1b85… PS1, Line 2014: type AVP_Unsigned32 AAA_3GPP_AAR_Flags trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/4bdabbde_1e47… PS1, Line 2018: type AVP_Unsigned32 AAA_3GPP_IMEI_Check_In_VPLMN_Result trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14867): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/9f902424_20d4… PS1, Line 2022: type AVP_Unsigned32 AAA_3GPP_ERP_Authorization trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17f7f025ff31d9ce619cd23bfa5f1af282969dbf Gerrit-Change-Number: 36162 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 05 Mar 2024 10:53:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment