Attention is currently required from: osmith, pespin, daniel. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29870 ) Change subject: osmux: Generate AMR OA payload paddings bits as 0 ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File library/AMR_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29870/comment/2c708563_8f1f… PS1, Line 38: Maybe add a comment here as well like: /* AMR voice frame length (in bits), * See also RFC 3267, chapter .... */ File library/OSMUX_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29870/comment/76254390_d3d7… PS1, Line 384: /* Generate the AMR payload as a bitstring, since some formats dont'e dn up in octet boundary: */ interesting typo: dont'e dn up -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29870 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5bc68eb05c2f5500a259f4c73d14b51794f7f078 Gerrit-Change-Number: 29870 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Oct 2022 08:36:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment