Attention is currently required from: daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30157 )
Change subject: osmux: Rotate over available Osmux CID when allocating a new one
......................................................................
Patch Set 1:
(2 comments)
File src/libosmo-mgcp/mgcp_osmux.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/30157/comment/d7066570_fdce8898
PS1, Line 748: start_j = next_free_osmux_cid_lookup & 0x07;
It didn't immediately occur to me, but no strong opinion. […]
Ack
https://gerrit.osmocom.org/c/osmo-mgw/+/30157/comment/05ee1400_1be1dd0b
PS1, Line 771: (i * 8)
here
you mean << not >> here :)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/30157
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I9dfbcc5e4b4c61ce217020e533d68fbcfa6b9f56
Gerrit-Change-Number: 30157
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Tue, 15 Nov 2022 17:05:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: daniel
dwillmann@sysmocom.de
Gerrit-MessageType: comment